DrawOverFov#6530
Open
Pok27 wants to merge 1 commit intospace-wizards:masterfrom
Open
Conversation
2 tasks
Member
I'm gonna be honest, that after screenshot still looks terrible. |
PJB3005
added
T: New Feature
Contributor
|
yeah, im not really sure theres a noticeable difference in quality between the two there |
Contributor
Author
|
The main problem with the smoke right now is the wall shadows, which I think can be turned off in the prototype. But it's still better |
Member
|
I'm really not a fan of adding any additional complexity into our garbage renderer for a feature that still isn't actually acceptable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for rendering selected sprites above FOV via
DrawOverFovand a dedicatedDrawEntitiesOverFovpass. Sprites marked withDrawOverFovare now skipped during the normal entity pass, collected while preserving the existing draw ordering, and rendered after FOV has been applied so they remain visible on top of it.This will make effects like smoke look better.
before
after
