Fix escaped quotes in formatted message parameters.#6547
Open
rhailrake wants to merge 1 commit intospace-wizards:masterfrom
Open
Fix escaped quotes in formatted message parameters.#6547rhailrake wants to merge 1 commit intospace-wizards:masterfrom
rhailrake wants to merge 1 commit intospace-wizards:masterfrom
Conversation
PJB3005
added
Priority: 2-Important
T: Bugfix
PJB3005
reviewed
May 5, 2026
Member
PJB3005
left a comment
PJB3005
left a comment
There was a problem hiding this comment.
I think I'd prefer if " was only escaped when inside a parameter, instead of in all cases.
rhailrake
force-pushed
the
fix/6537-formatted-message-quotes
branch
from
90db1e6 to
108019e
Compare
Contributor
Author
Sure! Adjusted this so |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #6537.
Quoted string parameters now parse escaped characters correctly.
This makes markup like
[tag="te\"xt"]parse normally instead of failing or falling back to text in permissive parsing.String parameter serialization now escapes quotes only inside parameter values, so
ToMarkup()round-trips quoted parameter values correctly without changing plain text escaping.