[Dependency] source generator#6549
Merged
PJB3005 merged 6 commits intospace-wizards:masterfrom May 8, 2026
Merged
Conversation
PJB3005
added
T: Performance
No more reflection, no more codegen at runtime Also various changes to Roslyn helpers to make this easier to write. Requires all types with dependencies to be partial and not have readonly dependency fields. An analyzer enforces this at warning level, the previous injection strategies have remained in the code *for now* as a fallback. No fallback is available for [field: Dependency] properties, due to a Roslyn bug. Code Fixes exist. We love Roslyn
PJB3005
force-pushed
the
26-05-04-ioc-source-gen
branch
from
a5f7a60 to
29a40e4
Compare
Contributor
|
It's.. it's beautiful 😭 |
moonheart08
previously requested changes
May 5, 2026
|
|
||
| private static void WriteGetDependencies(ref IndentWriter sb, EquatableArray<FieldInfo> fields, bool isOverride) | ||
| { | ||
| sb.AppendLineIndented("return ["); |
Contributor
There was a problem hiding this comment.
I'm not sure the use of the new list initializer syntax is actually sandbox safe and until we guarantee that we should just avoid it.
These are bad but gotta deal with it.
Co-authored-by: Moony <moony@hellomouse.net>
PJB3005
added
A: Roslyn Components
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No more reflection, no more codegen at runtime
Also various changes to Roslyn helpers to make this easier to write.
Requires all types with dependencies to be partial and not have readonly dependency fields. An analyzer enforces this at warning level, the previous injection strategies have remained in the code for now as a fallback.
No fallback is available for [field: Dependency] properties, due to a Roslyn bug.
Code Fixes exist. We love Roslyn