Add strict flag for keybinds to prevent key binding clashes#6595
Open
Elpersonn wants to merge 9 commits into
Open
Add strict flag for keybinds to prevent key binding clashes#6595Elpersonn wants to merge 9 commits into
Elpersonn wants to merge 9 commits into
Conversation
PJB3005
requested changes
May 26, 2026
Member
PJB3005
left a comment
PJB3005
left a comment
There was a problem hiding this comment.
You're never unsetting the flag here.
Honestly it'd probably be better to just figure out how to make the ctrl+a keybind do nothing when ctrl+alt+a is pressed. Maybe a flag to disallow the keybind to trigger if unecessary modifiers are active?
PJB3005
added
A: UI
Elpersonn
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a
strictModifiersflag for all keybinds, making it so a keybind with this flag will work only when the specified modifier keys are pressed.Closes #6592