Add optional modifier keys to bind command#6602
Open
iaada wants to merge 2 commits into
Open
Conversation
iaada
added
T: New Feature
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have a problem: I've run out of available keybinds. My solution was to use
execto have keybind scripts unique to each of my characters, but the command didn't support modifiers. This severely limited what I wanted to do with it, so I made this PR to add that support.This PR adds 3 optional params to
bindwhich set the modifiers for the keybind registration. It additionally adds the missing description and help forsvbind.