Refactor(?) SpawnNextToOrDrop, allow DropNextTo to take an offset#6605
Open
SnappingOpossum wants to merge 3 commits into
Open
Refactor(?) SpawnNextToOrDrop, allow DropNextTo to take an offset#6605SnappingOpossum wants to merge 3 commits into
SnappingOpossum wants to merge 3 commits into
Conversation
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires space-wizards/space-station-14#44204
Made it use
Entity<T>, allowed spawns to be offset, had it spawn with the overrides on fail, and made it only run mapinit after putting the entity in place and use aCreateEntityUnitializedlike some other spawn methods do.Initially did this just because I wanted to be able to offset things and use SpawnNextToOrDrop, and felt like I might as well make it
Entity<T>and fix the issues caused by its early initialisation while I'm at it. The conversion toEntity<TransformComponent?>does mean some otherEntity<T>uses have to be explicitly converted to an EntityUid first, but given how little it's used that was only three files in content