Merged
Conversation
klpoland
force-pushed
the
feature-kpoland-public-datasets-view
branch
from
2c69a33 to
9bee670
Compare
klpoland
force-pushed
the
feature-kpoland-public-datasets-view
branch
from
9bee670 to
b233070
Compare
lucaspar
added
the
javascript
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a public datasets search feature, allowing users to discover and search published datasets without authentication. The implementation includes new view classes for searching published datasets, a search form with filtering capabilities (text search, keywords, and frequency range), and corresponding templates and JavaScript components.
Changes:
- Added
SearchPublishedDatasetsViewandHomePageViewclasses with search and filtering functionality - Created
PublishedDatasetSearchFormfor dataset search with query, keywords, and frequency filters - Refactored existing templates to use partials for better code reuse
- Added JavaScript components for keyword chip input and dataset search handling
Reviewed changes
Copilot reviewed 14 out of 14 changed files in this pull request and generated 11 comments.
Show a summary per file
| File | Description |
|---|---|
| gateway/sds_gateway/users/views.py | Added SearchPublishedDatasetsView and HomePageView classes with search filtering methods; methods duplicated from ListDatasetsView |
| gateway/sds_gateway/users/urls.py | Added URL pattern for search_datasets endpoint |
| gateway/sds_gateway/users/forms.py | Added PublishedDatasetSearchForm with query, keywords, and frequency fields |
| gateway/sds_gateway/templates/users/search_datasets.html | New template for dataset search page (has critical template variable naming bugs) |
| gateway/sds_gateway/templates/users/published_datasets_list.html | New template that includes search tab partial |
| gateway/sds_gateway/templates/users/partials/search_published_datasets_tab.html | Partial template for search results display |
| gateway/sds_gateway/templates/users/partials/my_datasets_tab.html | Refactored partial extracted from dataset_list.html |
| gateway/sds_gateway/templates/users/partials/dataset_search_form.html | Reusable search form partial (has critical form ID and duplicate name attribute bugs) |
| gateway/sds_gateway/templates/users/dataset_list.html | Refactored to use my_datasets_tab.html partial |
| gateway/sds_gateway/templates/pages/home.html | Enhanced with latest datasets display and search form (has critical JavaScript syntax error) |
| gateway/sds_gateway/static/js/search/KeywordChipInput.js | New JavaScript component for keyword chip input functionality |
| gateway/sds_gateway/static/js/search/DatasetSearchHandler.js | New JavaScript handler for dataset search interactions |
| gateway/sds_gateway/static/css/components.css | Added CSS styles for keyword chip components |
| gateway/config/urls.py | Updated home page to use new HomePageView instead of TemplateView |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
gateway/sds_gateway/templates/users/partials/dataset_search_form.html
Outdated
Show resolved
Hide resolved
gateway/sds_gateway/templates/users/partials/search_published_datasets_tab.html
Show resolved
Hide resolved
lucaspar
reviewed
Jan 22, 2026
lucaspar
requested changes
Jan 26, 2026
lucaspar
approved these changes
Jan 27, 2026
Collaborator
Author
|
dataset submission works now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.