Re-enable commits on filtered databases #599
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't need to create new location records if we're updating the locations through entity from non-existent to None.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #599 +/- ##
==========================================
+ Coverage 85.48% 85.63% +0.15%
==========================================
Files 81 81
Lines 10929 11002 +73
Branches 1601 1617 +16
==========================================
+ Hits 9343 9422 +79
+ Misses 1228 1222 -6
Partials 358 358 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Implemented a new conflict fixing mechanism that commits modified items directory to a secondary unfiltered database mapping. The secondary mapping allows real integrity checks - we just need to update the item statuses (and ids in case of added items) in the original database mapping to committed state. Re #594
soininen
force-pushed
the
594_fix_cascade_remove
branch
from
33dbb0f to
5fd4394
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the database corrupting issues that forced us to disable commits on filtered databases.
Fixes #594
Checklist before merging