Skip to content

fix: java update pre commit #471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mkolasinski-splunk merged 3 commits into from
Mar 5, 2026
Merged

fix: java update pre commit #471

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a7dd25d
fix: Add Java setup step to pre-commit
mkolasinski-splunk Mar 5, 2026
902fadf
Change Java version from 25 to 17 in workflow
mkolasinski-splunk Mar 5, 2026
f5aeefb
Update error message for GS Scorecard requirement
mkolasinski-splunk Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion .github/workflows/reusable-build-test-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -468,6 +468,10 @@ jobs:
- uses: actions/setup-python@v5
with:
python-version: ${{ env.PYTHON_VERSION }}
- uses: actions/setup-java@v5
with:
distribution: 'temurin'
java-version: '17'
- uses: pre-commit/action@v3.0.1

review_secrets:
Expand Down Expand Up @@ -2933,7 +2937,7 @@ jobs:
# GS Scorecard: must have run for PRs to main (result doesn't matter, but skipped = blocked)
GS_RESULT=$(echo "$NEEDS" | jq -r '.["run-gs-scorecard"].result')
if [[ "${{ github.event_name }}" == "pull_request" ]] && [[ "${{ github.base_ref }}" == "main" ]] && [[ "$GS_RESULT" == "skipped" ]]; then
echo "::error::GS Scorecard is required for PRs to main. Add the 'execute_gs_scorecard' label and re-run the workflow."
echo "::error::GS Scorecard is required for merging PRs to main. To unblock merging please add the 'execute_gs_scorecard' label and re-run the workflow."
echo "## GS Scorecard Required" >> "$GITHUB_STEP_SUMMARY"
echo "Add the \`execute_gs_scorecard\` label to this PR and re-run the workflow. GS Scorecard must complete before merging to main (result does not need to pass)." >> "$GITHUB_STEP_SUMMARY"
echo "run-publish=false" >> "$GITHUB_OUTPUT"
Expand Down
Loading