Added configurable interaction matching.#1308
Closed
CamilYed wants to merge 4 commits intospockframework:masterfrom
CamilYed:master
Closed
Added configurable interaction matching.#1308CamilYed wants to merge 4 commits intospockframework:masterfrom CamilYed:master
CamilYed wants to merge 4 commits intospockframework:masterfrom
CamilYed:master
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1308 +/- ##
============================================
+ Coverage 79.14% 79.16% +0.01%
- Complexity 3922 3927 +5
============================================
Files 409 409
Lines 12235 12253 +18
Branches 1610 1615 +5
============================================
+ Hits 9684 9700 +16
- Misses 1970 1971 +1
- Partials 581 582 +1
Continue to review full report at Codecov.
|
added 2 commits
April 7, 2021 23:10
# Conflicts: # spock-specs/src/test/groovy/org/spockframework/smoke/mock/InteractionScopeMatching.groovy
Author
|
Could you review my changes: @szpak ? |
Member
|
Spock 2.0 is in feature freeze at the moment |
Author
|
Not for 2.0 now |
Member
|
@KamilJedrzejuk you didn't have to close this PR, the Spock 2.0 release is not far off, that's why we won't merge new features. We will review it afterwards. |
Author
|
Hi, what about this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added 'last match algorithm' to determine the defined return value of a
method. This enables easy overriding of default return values. As
requested in issue #26, #251, #321 and #962.