Open
Conversation
hkpeprah
requested changes
Mar 1, 2021
Contributor
hkpeprah
left a comment
There was a problem hiding this comment.
LGTM. Thanks for the changes. Sorry it took me so long to get back to this. Could you add unit tests for the function you introduced? Otherwise, besides the minor comments, LGTM.
Author
|
No worries on lag - considering the state of the world I hardly think 2 weeks delay for some JTAG raw access is worth apologizing over ;-) I'll figure out the unit test thing - will fix the easy issues first then comment again once tests are there (hadn't looked at how they were working in this repo). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds a single feature from the 'raw jtag' API allowing TMS/TDI/TDO control. This is useful to implement boundary scan mode (which I'm working on in another library called pyjtagbs). Other raw commands could be added, but are harder to use in practice as they require more information about the scan chain sent to the J-Link, most software seems to use this API only.
You should be able to use the code like this:
If a single item - will just see 4 bytes. You can print the
hex_idto see the standard format - testing on a Spartan 6 LX9 shows me0x3622093which matches the expected device id.Note there is no .connect() - you can't connect to the chain as that will start trying to discover devices on it (which may be unsupported devices).