Replace slashes by underscores and not colons#1457
Merged
Conversation
Having colons in the object names causes issues with URL generation and fsspec, since colons have a special meaning in URL parsing and fsspec language. Underscores are much more neutral.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1457 +/- ##
========================================
Coverage 88.94% 88.94%
========================================
Files 103 103
Lines 3689 3689
Branches 453 453
========================================
Hits 3281 3281
Misses 333 333
Partials 75 75 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Having colons in the object names causes issues with URL generation and fsspec, since colons have a special meaning in URL parsing and fsspec language. Underscores are much more neutral.