Skip to content

fix: asset __eq__#1660

Merged
jsignell merged 1 commit intov2from
v2-fix-asset-eq
Apr 7, 2026
Merged

fix: asset __eq__#1660
jsignell merged 1 commit intov2from
v2-fix-asset-eq

Conversation

@jsignell
Copy link
Copy Markdown
Member

Fix asset __eq__ as recommended in #1646 (comment)

Comment thread src/pystac/asset.py
Comment thread tests/v1/test_item_assets.py
@jsignell jsignell changed the title Fix asset __eq__ fix: asset __eq__ Mar 29, 2026
@jsignell
Copy link
Copy Markdown
Member Author

These test failures probably should have been caught in #1658 @ircwaves but it looks like for some reason github actions didn't run the full matrix of tests on that PR.

@ircwaves
Copy link
Copy Markdown
Member

These test failures probably should have been caught in #1658 but it looks like for some reason github actions didn't run the full matrix of tests on that PR.

Yeah, not sure why that didn't run, but I think it makes sense for you to slap the skip back on so this isn't impeded, and I'll sort that out in the changes I'm working for v1/test_link.

@jsignell jsignell merged commit 00c2656 into v2 Apr 7, 2026
12 of 16 checks passed
@jsignell jsignell deleted the v2-fix-asset-eq branch April 7, 2026 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants