Skip to content

Make gres.conf world readable like slurm.conf#213

Merged
elelaysh merged 1 commit into
masterfrom
fix/gres-conf-permissions
May 22, 2026
Merged

Make gres.conf world readable like slurm.conf#213
elelaysh merged 1 commit into
masterfrom
fix/gres-conf-permissions

Conversation

@elelaysh
Copy link
Copy Markdown
Contributor

@elelaysh elelaysh commented Mar 2, 2026

and owned by root

@elelaysh elelaysh requested a review from a team as a code owner March 2, 2026 13:21
@elelaysh elelaysh requested a review from sjpb March 2, 2026 13:21
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the file permissions and ownership of gres.conf to make them consistent with slurm.conf. The file mode is changed to 0644 (world-readable), and the owner and group are set to root. This is a reasonable change as gres.conf does not typically contain sensitive information. The implementation is correct and achieves the goal described in the pull request.

@elelaysh elelaysh merged commit c2aff51 into master May 22, 2026
27 checks passed
@elelaysh elelaysh deleted the fix/gres-conf-permissions branch May 22, 2026 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants