Skip to content

Conversation

@Alex-Welsh
Copy link
Member

@Alex-Welsh Alex-Welsh commented Jan 12, 2026

Release train CI has been broken since Friday (9th january)
Looks like it was caused by this release https://github.com/actions/runner/releases/tag/v2.331.0
The scary thing is this line:

Bump docker image to use ubuntu 24.04 by @TingluoHuang in #4018

Here’s a “before” working action: https://github.com/stackhpc/stackhpc-release-train/actions/runs/20829990903/job/59848189367#step:1:1
Here’s an “after” broken action: https://github.com/stackhpc/stackhpc-release-train/actions/runs/20863962427/job/59970626801#step:1:1

And here's a test sync with the fix: https://github.com/stackhpc/stackhpc-release-train/actions/runs/20925861913

@Alex-Welsh Alex-Welsh requested a review from a team as a code owner January 12, 2026 15:56
@gemini-code-assist
Copy link

Summary of Changes

Hello @Alex-Welsh, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves package synchronization failures observed on new Noble runners within the CI/CD pipeline. It updates the Python setup action and introduces explicit installation steps for critical Python tools like pip and setuptools, utilizing methods compatible with the latest Ubuntu distributions. These changes ensure that Ansible dependencies can be reliably managed and installed, preventing build failures related to Python environment setup.

Highlights

  • Python Setup Action Update: The actions/setup-python action has been updated from version 5 to version 6, ensuring compatibility with newer environments and features.
  • Explicit Pip Installation: Added steps to explicitly install python3-pip using apt on the runner, addressing issues where pip might not be readily available or correctly configured on new Noble runners.
  • Setuptools Installation Fix: Included a new step to install setuptools using /usr/bin/python3 -m pip with the --break-system-packages flag. This resolves compatibility challenges with system Python environments on recent Ubuntu distributions like Noble.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@Alex-Welsh Alex-Welsh requested a review from m-bull January 12, 2026 15:58
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to fix package synchronization on new Noble runners by adjusting the GitHub Actions setup. The changes involve reordering Python setup, updating an action version, and adding steps to install Python dependencies for Ansible on the client side, specifically addressing changes in Ubuntu 24.04 (Noble). My review has identified a critical issue with an invalid action version that will cause the workflow to fail. I've also provided suggestions to improve the clarity and robustness of the workflow script, such as using unique names for steps and employing apt-get for better script stability.

@Alex-Welsh
Copy link
Member Author

One last check to see if we can fix this in a better way https://github.com/stackhpc/stackhpc-release-train/actions/runs/20926270376/job/60124920487

@Alex-Welsh Alex-Welsh merged commit c8ac8a3 into main Jan 12, 2026
5 checks passed
@Alex-Welsh Alex-Welsh deleted the fix-package-sync-2 branch January 12, 2026 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants