-
Notifications
You must be signed in to change notification settings - Fork 1
Fix package sync on new Noble runners #466
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @Alex-Welsh, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request resolves package synchronization failures observed on new Noble runners within the CI/CD pipeline. It updates the Python setup action and introduces explicit installation steps for critical Python tools like Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request aims to fix package synchronization on new Noble runners by adjusting the GitHub Actions setup. The changes involve reordering Python setup, updating an action version, and adding steps to install Python dependencies for Ansible on the client side, specifically addressing changes in Ubuntu 24.04 (Noble). My review has identified a critical issue with an invalid action version that will cause the workflow to fail. I've also provided suggestions to improve the clarity and robustness of the workflow script, such as using unique names for steps and employing apt-get for better script stability.
|
One last check to see if we can fix this in a better way https://github.com/stackhpc/stackhpc-release-train/actions/runs/20926270376/job/60124920487 |
Release train CI has been broken since Friday (9th january)
Looks like it was caused by this release https://github.com/actions/runner/releases/tag/v2.331.0
The scary thing is this line:
Here’s a “before” working action: https://github.com/stackhpc/stackhpc-release-train/actions/runs/20829990903/job/59848189367#step:1:1
Here’s an “after” broken action: https://github.com/stackhpc/stackhpc-release-train/actions/runs/20863962427/job/59970626801#step:1:1
And here's a test sync with the fix: https://github.com/stackhpc/stackhpc-release-train/actions/runs/20925861913