Skip to content

Mark fields in the runconfig as deprecated #2212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
+46 −18
Open

Mark fields in the runconfig as deprecated #2212

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
038a132
Mark fields in the runconfig as deprecated
dmjb Oct 15, 2025
36857b8
update docs
dmjb Oct 15, 2025
b3d62c1
Merge branch 'main' into deprecated-fields
dmjb Nov 6, 2025
2b91efa
Merge branch 'main' into deprecated-fields
dmjb Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/server/docs.go
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion docs/server/swagger.json
View file
Open in desktop

Large diffs are not rendered by default.

49 changes: 33 additions & 16 deletions docs/server/swagger.yaml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 11 additions & 0 deletions pkg/runner/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,6 +84,7 @@ type RunConfig struct {
// EnvVars are the parsed environment variables as key-value pairs
EnvVars map[string]string `json:"env_vars,omitempty" yaml:"env_vars,omitempty"`

// DEPRECATED: No longer appears to be used.
// EnvFileDir is the directory path to load environment files from
EnvFileDir string `json:"env_file_dir,omitempty" yaml:"env_file_dir,omitempty"`

Expand All @@ -97,21 +98,27 @@ type RunConfig struct {
// ContainerLabels are the labels to apply to the container
ContainerLabels map[string]string `json:"container_labels,omitempty" yaml:"container_labels,omitempty"`

// DEPRECATED: Middleware configuration.
// OIDCConfig contains OIDC configuration
OIDCConfig *auth.TokenValidatorConfig `json:"oidc_config,omitempty" yaml:"oidc_config,omitempty"`

// DEPRECATED: Middleware configuration.
// AuthzConfig contains the authorization configuration
AuthzConfig *authz.Config `json:"authz_config,omitempty" yaml:"authz_config,omitempty"`

// DEPRECATED: Middleware configuration.
// AuthzConfigPath is the path to the authorization configuration file
AuthzConfigPath string `json:"authz_config_path,omitempty" yaml:"authz_config_path,omitempty"`

// DEPRECATED: Middleware configuration.
// AuditConfig contains the audit logging configuration
AuditConfig *audit.Config `json:"audit_config,omitempty" yaml:"audit_config,omitempty"`

// DEPRECATED: Middleware configuration.
// AuditConfigPath is the path to the audit configuration file
AuditConfigPath string `json:"audit_config_path,omitempty" yaml:"audit_config_path,omitempty"`

// DEPRECATED: Middleware configuration.
// TelemetryConfig contains the OpenTelemetry configuration
TelemetryConfig *telemetry.Config `json:"telemetry_config,omitempty" yaml:"telemetry_config,omitempty"`

Expand All @@ -138,18 +145,22 @@ type RunConfig struct {
// ProxyMode is the proxy mode for stdio transport ("sse" or "streamable-http")
ProxyMode types.ProxyMode `json:"proxy_mode,omitempty" yaml:"proxy_mode,omitempty"`

// DEPRECATED: No longer appears to be used.
// ThvCABundle is the path to the CA certificate bundle for ToolHive HTTP operations
ThvCABundle string `json:"thv_ca_bundle,omitempty" yaml:"thv_ca_bundle,omitempty"`

// DEPRECATED: No longer appears to be used.
// JWKSAuthTokenFile is the path to file containing auth token for JWKS/OIDC requests
JWKSAuthTokenFile string `json:"jwks_auth_token_file,omitempty" yaml:"jwks_auth_token_file,omitempty"`

// Group is the name of the group this workload belongs to, if any
Group string `json:"group,omitempty" yaml:"group,omitempty"`

// DEPRECATED: Middleware configuration.
// ToolsFilter is the list of tools to filter
ToolsFilter []string `json:"tools_filter,omitempty" yaml:"tools_filter,omitempty"`

// DEPRECATED: Middleware configuration.
// ToolsOverride is a map from an actual tool to its overridden name and/or description
ToolsOverride map[string]ToolOverride `json:"tools_override,omitempty" yaml:"tools_override,omitempty"`

Expand Down
Loading