[SerperRM Bug] #236
Merged
[SerperRM Bug] #236
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valid_url_to_snippets.get(url, {}) get none value.
call strip function will be fix it. just like url.strip("\'")
Collaborator
|
Hi @zhoucheng89 , it seems like the format check fails so I cannot merge this due to our repository rule. Could you run the following: Thanks! |
valid_url_to_snippets.get(url, {}) get none value.
call strip function will be fix it. just like url.strip("\'").
format code and commit.
Contributor
Author
|
@shaoyijia Thank you for your reminder. I have formatted the code as you suggested. Please confirm again. Thanks! |
shaoyijia
approved these changes
Oct 27, 2024
Collaborator
shaoyijia
left a comment
shaoyijia
left a comment
There was a problem hiding this comment.
Thank you for your contribution!
Contributor
Author
|
@shaoyijia Can you merge this commit into the dev-Chinese branch? As I am debugging this branch, it requires synchronized and fixed code |
Collaborator
|
done. |
feldges
pushed a commit
to feldges/storm
that referenced
this pull request
Dec 4, 2024
Fix SerperRM bug.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
valid_url_to_snippets.get(url, {}) get none value. call strip function will be fix it. just like url.strip("'")