Add Version struct and version field to PrivacyProofOutput#349
Add Version struct and version field to PrivacyProofOutput#349gilbens-starkware wants to merge 1 commit into
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #349 +/- ##
==========================================
+ Coverage 59.17% 59.28% +0.11%
==========================================
Files 35 36 +1
Lines 5303 5318 +15
==========================================
+ Hits 3138 3153 +15
Misses 2165 2165
🚀 New features to boost your workflow:
|
ce2cbec to
c5713f0
Compare
c5713f0 to
c4a15f4
Compare
Gali-StarkWare
left a comment
There was a problem hiding this comment.
@Gali-StarkWare reviewed 3 files and all commit messages, and made 3 comments.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on anatgstarkware and gilbens-starkware).
crates/privacy_circuit_verify/src/utils.rs line 8 at r1 (raw file):
impl Version { /// Returns the version of the privacy crates (shared workspace version).
shared workspace version?
Code quote:
/// Returns the version of the privacy crates (shared workspace version).crates/privacy_circuit_verify/src/utils.rs line 43 at r1 (raw file):
env!("CARGO_PKG_VERSION_PATCH").parse::<u8>().unwrap() ); }
What is the point of this test? It's comparing the same expression
Code quote:
#[test]
fn test_version_current() {
let version = Version::current();
assert_eq!(
version.major,
env!("CARGO_PKG_VERSION_MAJOR").parse::<u8>().unwrap()
);
assert_eq!(
version.minor,
env!("CARGO_PKG_VERSION_MINOR").parse::<u8>().unwrap()
);
assert_eq!(
version.patch,
env!("CARGO_PKG_VERSION_PATCH").parse::<u8>().unwrap()
);
}7f70fc0 to
41a78b3
Compare
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
41a78b3 to
02876ea
Compare
Gali-StarkWare
left a comment
There was a problem hiding this comment.
@Gali-StarkWare reviewed 2 files and all commit messages, made 1 comment, and resolved 2 discussions.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on anatgstarkware).
Type
Description
Breaking changes?
This change is