Skip to content

Add Version struct and version field to PrivacyProofOutput#349

Open
gilbens-starkware wants to merge 1 commit into
mainfrom
gil/proof_version
Open

Add Version struct and version field to PrivacyProofOutput#349
gilbens-starkware wants to merge 1 commit into
mainfrom
gil/proof_version

Conversation

@gilbens-starkware
Copy link
Copy Markdown
Contributor

@gilbens-starkware gilbens-starkware commented May 27, 2026

Type

  • feature
  • bugfix
  • dev (no functional changes, no API changes)
  • fmt (formatting, renaming)
  • build
  • docs
  • testing

Description

Breaking changes?

  • yes
  • no

This change is Reviewable

@codecov
Copy link
Copy Markdown

codecov Bot commented May 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.28%. Comparing base (8616d30) to head (02876ea).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #349      +/-   ##
==========================================
+ Coverage   59.17%   59.28%   +0.11%     
==========================================
  Files          35       36       +1     
  Lines        5303     5318      +15     
==========================================
+ Hits         3138     3153      +15     
  Misses       2165     2165              
Files with missing lines Coverage Δ
crates/privacy_circuit_verify/src/lib.rs 97.72% <ø> (ø)
crates/privacy_circuit_verify/src/utils.rs 100.00% <100.00%> (ø)
crates/privacy_prove/src/lib.rs 97.72% <100.00%> (+0.02%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gilbens-starkware gilbens-starkware force-pushed the gil/proof_version branch 4 times, most recently from ce2cbec to c5713f0 Compare May 27, 2026 09:28
Copy link
Copy Markdown
Contributor

@Gali-StarkWare Gali-StarkWare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: with comments

@Gali-StarkWare reviewed 3 files and all commit messages, and made 3 comments.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on anatgstarkware and gilbens-starkware).


crates/privacy_circuit_verify/src/utils.rs line 8 at r1 (raw file):

impl Version {
    /// Returns the version of the privacy crates (shared workspace version).

shared workspace version?

Code quote:

/// Returns the version of the privacy crates (shared workspace version).

crates/privacy_circuit_verify/src/utils.rs line 43 at r1 (raw file):

            env!("CARGO_PKG_VERSION_PATCH").parse::<u8>().unwrap()
        );
    }

What is the point of this test? It's comparing the same expression

Code quote:

    #[test]
    fn test_version_current() {
        let version = Version::current();
        assert_eq!(
            version.major,
            env!("CARGO_PKG_VERSION_MAJOR").parse::<u8>().unwrap()
        );
        assert_eq!(
            version.minor,
            env!("CARGO_PKG_VERSION_MINOR").parse::<u8>().unwrap()
        );
        assert_eq!(
            version.patch,
            env!("CARGO_PKG_VERSION_PATCH").parse::<u8>().unwrap()
        );
    }

@gilbens-starkware gilbens-starkware force-pushed the gil/proof_version branch 10 times, most recently from 7f70fc0 to 41a78b3 Compare May 28, 2026 08:15
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Copy link
Copy Markdown
Contributor

@Gali-StarkWare Gali-StarkWare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@Gali-StarkWare reviewed 2 files and all commit messages, made 1 comment, and resolved 2 discussions.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on anatgstarkware).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants