Skip to content

Yuval/verifier for 0.14.3#350

Open
yuvalsw wants to merge 2 commits into
ilya/check_log_sizefrom
yuval/verifier_for_0.14.3
Open

Yuval/verifier for 0.14.3#350
yuvalsw wants to merge 2 commits into
ilya/check_log_sizefrom
yuval/verifier_for_0.14.3

Conversation

@yuvalsw
Copy link
Copy Markdown
Collaborator

@yuvalsw yuvalsw commented May 27, 2026

Type

  • feature
  • bugfix
  • dev (no functional changes, no API changes)
  • fmt (formatting, renaming)
  • build
  • docs
  • testing

Description

Breaking changes?

  • yes
  • no

This change is Reviewable

@cursor
Copy link
Copy Markdown

cursor Bot commented May 27, 2026

PR Summary

Medium Risk
Touches the entire Cairo compile/run toolchain and proof-related crates; behavior changes in 2.19 RC could affect program execution and verification without local code changes in this diff.

Overview
Bumps the workspace cairo-lang stack from 2.17.0-rc.3 to 2.19.0-rc.0 for cairo-lang-executable, cairo-lang-runner, cairo-lang-casm, and cairo-lang-execute-utils, and adds cairo-lang-utils at the same version (wired into cairo-program-runner-lib via workspace deps).

Cargo.lock is refreshed so the full transitive cairo-lang 2.19.0-rc.0 tree is pinned, and several stwo / stwo-circuits dependencies move from hashbrown 0.15.5 to 0.17.0 to match the upgraded graph.

Reviewed by Cursor Bugbot for commit c110370. Bugbot is set up for automated code reviews on this repo. Configure here.

@ilyalesokhin-starkware
Copy link
Copy Markdown
Contributor

crates/privacy_circuit_verify/src/consts.rs line 58 at r1 (raw file):

/// prints the expected value to paste here.
pub const CIRCUIT_LOG_COMPONENT_SIZES: [u32; 15] =
    [17, 21, 14, 17, 4, 20, 13, 17, 16, 20, 8, 14, 18, 15, 16];

Suggestion:

pub const CIRCUIT_LOG_COMPONENT_SIZES: [u32; 15] =
    [17, 22, 14, 17, 4, 20, 13, 17, 16, 20, 8, 14, 18, 15, 16];

@yuvalsw yuvalsw changed the base branch from main to ilya/check_log_size May 27, 2026 14:06
@yuvalsw
Copy link
Copy Markdown
Collaborator Author

yuvalsw commented May 27, 2026

crates/privacy_circuit_verify/src/consts.rs line 58 at r1 (raw file):

/// prints the expected value to paste here.
pub const CIRCUIT_LOG_COMPONENT_SIZES: [u32; 15] =
    [17, 21, 14, 17, 4, 20, 13, 17, 16, 20, 8, 14, 18, 15, 16];

I guess the 21->22 is the blake_compress component? I should have a test failing, shouldn't I? How else can I know the rest of the numbers here are correct after the change?

@yuvalsw yuvalsw force-pushed the yuval/verifier_for_0.14.3 branch from 6c726b1 to 57226d5 Compare May 27, 2026 15:11
@codecov
Copy link
Copy Markdown

codecov Bot commented May 27, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 53.35%. Comparing base (580135e) to head (c110370).

Additional details and impacted files
@@                 Coverage Diff                  @@
##           ilya/check_log_size     #350   +/-   ##
====================================================
  Coverage                53.35%   53.35%           
====================================================
  Files                       36       36           
  Lines                     5295     5295           
====================================================
  Hits                      2825     2825           
  Misses                    2470     2470           
Files with missing lines Coverage Δ
crates/cairo-program-runner-lib/src/hints/types.rs 47.78% <ø> (ø)
crates/privacy_circuit_verify/src/consts.rs 0.00% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@yuvalsw yuvalsw force-pushed the yuval/verifier_for_0.14.3 branch from 57226d5 to 177571a Compare May 27, 2026 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants