Skip to content

Bump stwo-circuits.#355

Merged
ilyalesokhin-starkware merged 1 commit into
mainfrom
ilya/bump
May 28, 2026
Merged

Bump stwo-circuits.#355
ilyalesokhin-starkware merged 1 commit into
mainfrom
ilya/bump

Conversation

@ilyalesokhin-starkware
Copy link
Copy Markdown
Contributor

@ilyalesokhin-starkware ilyalesokhin-starkware commented May 28, 2026

Type

  • feature
  • bugfix
  • dev (no functional changes, no API changes)
  • fmt (formatting, renaming)
  • build
  • docs
  • testing

Description

Breaking changes?

  • yes
  • no

This change is Reviewable

@cursor
Copy link
Copy Markdown

cursor Bot commented May 28, 2026

PR Summary

High Risk
Changes STARK circuit verifier dependencies and the hardcoded preprocessed root used in recursive proof verification; mismatches would break or mis-verify proofs.

Overview
Bumps all stwo-circuits git dependencies from 9ff7fc8 to 618db0a in privacy_circuit_verify and privacy_prove, with Cargo.lock updated to match.

PRIVACY_RECURSION_CIRCUIT_PREPROCESSED_ROOT in crates/privacy_circuit_verify/src/consts.rs is replaced with the root expected by the new circuit revision so recursive privacy proof verification stays aligned with prove/verify behavior.

Reviewed by Cursor Bugbot for commit 1d2d446. Bugbot is set up for automated code reviews on this repo. Configure here.

Copy link
Copy Markdown
Collaborator

@yuvalsw yuvalsw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yuvalsw reviewed 3 files and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on leo-starkware).

Copy link
Copy Markdown
Collaborator

@yuvalsw yuvalsw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@yuvalsw made 1 comment.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on leo-starkware).

Copy link
Copy Markdown
Collaborator

@yuvalsw yuvalsw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yuvalsw reviewed 1 file and all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on leo-starkware).

@ilyalesokhin-starkware ilyalesokhin-starkware merged commit c0b937b into main May 28, 2026
11 checks passed
@ilyalesokhin-starkware ilyalesokhin-starkware deleted the ilya/bump branch May 28, 2026 15:24
@codecov
Copy link
Copy Markdown

codecov Bot commented May 28, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.19%. Comparing base (ea3b062) to head (1d2d446).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #355   +/-   ##
=======================================
  Coverage   59.19%   59.19%           
=======================================
  Files          35       35           
  Lines        5303     5303           
=======================================
  Hits         3139     3139           
  Misses       2164     2164           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Yoni-Starkware added a commit to starkware-libs/sequencer that referenced this pull request May 28, 2026
…3-rc-1

Follow-up to #14241 (which moved both to v0.14.3-rc-0). v0.14.3-rc-1 is the
proving-utils tag of commit c0b937b (PR starkware-libs/proving-utils#355,
"Bump stwo-circuits."), which advances the stwo-circuits revision from
9ff7fc8 to 618db0a. privacy-circuit-verify-v0 stays on 580135e.

stwo-circuits changes the on-chain proof bytes, so regenerate the three
serialized proof fixtures:
  - proof_flow/proof.bin (apollo_integration_tests) via
    `cargo test -p starknet_os_flow_tests --features
    starknet_transaction_prover/stwo_proving --release generate_proof_fixtures
    -- --ignored`
  - example_proof.bin (apollo_transaction_converter) via
    `cargo test -p starknet_transaction_prover --features stwo_proving
    --release -- --ignored regenerate_proof_fixtures`
  - regression_test/0.14.3/example_proof.bin (starknet_proof_verifier) is a
    copy of the apollo_transaction_converter fixture.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants