Skip to content

Conversation

@sirandreww-starkware
Copy link
Contributor

No description provided.

@reviewable-StarkWare
Copy link

This change is Reviewable

Copy link
Contributor Author

sirandreww-starkware commented Nov 18, 2025

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @Itay-Tsabary-Starkware and @ShahakShama)


.github/workflows/main.yml line 9 at r1 (raw file):

      - main-v[0-9].**
    tags:
      - v[0-9].**

you can delete this, I think

Code quote:

  push:
    branches:
      - main
      - main-v[0-9].**
    tags:
      - v[0-9].**

.github/workflows/main.yml line 80 at r1 (raw file):

      - name: "Run python code style pull request"
        if: github.event_name == 'pull_request'
        run: scripts/py_code_style.py

see above - pull_request this is the only event

Suggestion:

      # Run code style on PR.
      - name: "Run TODO style"
        run: scripts/named_todos.py --commit_id ${{ github.event.pull_request.base.sha }}
      - name: "Run clippy"
        run: scripts/run_tests.py --command clippy --changes_only --commit_id ${{ github.event.pull_request.base.sha }}
      - name: "Run cargo doc"
        run: scripts/run_tests.py --command doc --changes_only --commit_id ${{ github.event.pull_request.base.sha }}
      - name: "Run python code style"
        run: scripts/py_code_style.py

.github/workflows/main.yml line 128 at r1 (raw file):

        if: github.event_name == 'pull_request'
        run: |
          scripts/run_tests.py --command test --changes_only --include_dependencies --commit_id ${{ github.event.pull_request.base.sha }}

see above

Suggestion:

      - name: "Run tests pull request"
        run: |
          scripts/run_tests.py --command test --changes_only --include_dependencies --commit_id ${{ github.event.pull_request.base.sha }}

.github/workflows/main.yml line 134 at r1 (raw file):

  integration-tests-pr:
    if: github.event_name == 'pull_request'
    uses: ./.github/workflows/integration-tests.yml

see above

Suggestion:

  integration-tests-pr:
    uses: ./.github/workflows/integration-tests.yml

@sirandreww-starkware sirandreww-starkware force-pushed the 11-18-ci_removed_event_name_push_actions branch from 9fba020 to f2e7d25 Compare November 18, 2025 13:44
@sirandreww-starkware sirandreww-starkware force-pushed the 11-11-ci_run_all_the_integration_tests_on_pr_or_push branch from 5a0b7b3 to eae246a Compare November 18, 2025 13:44
Copy link
Contributor Author

@sirandreww-starkware sirandreww-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @dorimedini-starkware, @Itay-Tsabary-Starkware, and @ShahakShama)


.github/workflows/main.yml line 9 at r1 (raw file):

Previously, dorimedini-starkware wrote…

you can delete this, I think

Done.


.github/workflows/main.yml line 80 at r1 (raw file):

Previously, dorimedini-starkware wrote…

see above - pull_request this is the only event

Done.


.github/workflows/main.yml line 128 at r1 (raw file):

Previously, dorimedini-starkware wrote…

see above

Done.


.github/workflows/main.yml line 134 at r1 (raw file):

Previously, dorimedini-starkware wrote…

see above

Done.

Copy link
Contributor

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Conceptual :lgtm:

Reviewable status: 0 of 1 files reviewed, 4 unresolved discussions (waiting on @dorimedini-starkware and @ShahakShama)

Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

@dorimedini-starkware reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ShahakShama)

@sirandreww-starkware sirandreww-starkware force-pushed the 11-11-ci_run_all_the_integration_tests_on_pr_or_push branch from eae246a to da73968 Compare December 8, 2025 12:20
@sirandreww-starkware sirandreww-starkware force-pushed the 11-18-ci_removed_event_name_push_actions branch from f2e7d25 to ab5902e Compare December 8, 2025 12:20
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ShahakShama)

@sirandreww-starkware sirandreww-starkware force-pushed the 11-18-ci_removed_event_name_push_actions branch from ab5902e to b35602d Compare December 8, 2025 14:30
@sirandreww-starkware sirandreww-starkware force-pushed the 11-11-ci_run_all_the_integration_tests_on_pr_or_push branch 2 times, most recently from 76aa864 to bce5472 Compare December 9, 2025 07:42
@sirandreww-starkware sirandreww-starkware force-pushed the 11-18-ci_removed_event_name_push_actions branch 2 times, most recently from ab54d17 to c260e6d Compare December 9, 2025 07:45
@sirandreww-starkware sirandreww-starkware force-pushed the 11-11-ci_run_all_the_integration_tests_on_pr_or_push branch from bce5472 to 897ebdb Compare December 9, 2025 07:45
@sirandreww-starkware sirandreww-starkware force-pushed the 11-18-ci_removed_event_name_push_actions branch from c260e6d to e8a3591 Compare December 9, 2025 07:56
@sirandreww-starkware sirandreww-starkware force-pushed the 11-11-ci_run_all_the_integration_tests_on_pr_or_push branch from 897ebdb to 81d652d Compare December 9, 2025 07:56
Copy link
Collaborator

@dorimedini-starkware dorimedini-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dorimedini-starkware reviewed 1 of 1 files at r4, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @ShahakShama)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants