-
Notifications
You must be signed in to change notification settings - Fork 65
ci: removed event_name == 'push' actions #10230
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 11-11-ci_run_all_the_integration_tests_on_pr_or_push
Are you sure you want to change the base?
ci: removed event_name == 'push' actions #10230
Conversation
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
dorimedini-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dorimedini-starkware reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @Itay-Tsabary-Starkware and @ShahakShama)
.github/workflows/main.yml line 9 at r1 (raw file):
- main-v[0-9].** tags: - v[0-9].**
you can delete this, I think
Code quote:
push:
branches:
- main
- main-v[0-9].**
tags:
- v[0-9].**.github/workflows/main.yml line 80 at r1 (raw file):
- name: "Run python code style pull request" if: github.event_name == 'pull_request' run: scripts/py_code_style.py
see above - pull_request this is the only event
Suggestion:
# Run code style on PR.
- name: "Run TODO style"
run: scripts/named_todos.py --commit_id ${{ github.event.pull_request.base.sha }}
- name: "Run clippy"
run: scripts/run_tests.py --command clippy --changes_only --commit_id ${{ github.event.pull_request.base.sha }}
- name: "Run cargo doc"
run: scripts/run_tests.py --command doc --changes_only --commit_id ${{ github.event.pull_request.base.sha }}
- name: "Run python code style"
run: scripts/py_code_style.py.github/workflows/main.yml line 128 at r1 (raw file):
if: github.event_name == 'pull_request' run: | scripts/run_tests.py --command test --changes_only --include_dependencies --commit_id ${{ github.event.pull_request.base.sha }}
see above
Suggestion:
- name: "Run tests pull request"
run: |
scripts/run_tests.py --command test --changes_only --include_dependencies --commit_id ${{ github.event.pull_request.base.sha }}.github/workflows/main.yml line 134 at r1 (raw file):
integration-tests-pr: if: github.event_name == 'pull_request' uses: ./.github/workflows/integration-tests.yml
see above
Suggestion:
integration-tests-pr:
uses: ./.github/workflows/integration-tests.yml9fba020 to
f2e7d25
Compare
5a0b7b3 to
eae246a
Compare
sirandreww-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @dorimedini-starkware, @Itay-Tsabary-Starkware, and @ShahakShama)
.github/workflows/main.yml line 9 at r1 (raw file):
Previously, dorimedini-starkware wrote…
you can delete this, I think
Done.
.github/workflows/main.yml line 80 at r1 (raw file):
Previously, dorimedini-starkware wrote…
see above - pull_request this is the only event
Done.
.github/workflows/main.yml line 128 at r1 (raw file):
Previously, dorimedini-starkware wrote…
see above
Done.
.github/workflows/main.yml line 134 at r1 (raw file):
Previously, dorimedini-starkware wrote…
see above
Done.
Itay-Tsabary-Starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: 0 of 1 files reviewed, 4 unresolved discussions (waiting on @dorimedini-starkware and @ShahakShama)
dorimedini-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dorimedini-starkware reviewed 1 of 1 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @ShahakShama)
eae246a to
da73968
Compare
f2e7d25 to
ab5902e
Compare
dorimedini-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dorimedini-starkware reviewed 1 of 1 files at r3, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @ShahakShama)
ab5902e to
b35602d
Compare
76aa864 to
bce5472
Compare
ab54d17 to
c260e6d
Compare
bce5472 to
897ebdb
Compare
c260e6d to
e8a3591
Compare
897ebdb to
81d652d
Compare
dorimedini-starkware
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dorimedini-starkware reviewed 1 of 1 files at r4, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @ShahakShama)

No description provided.