Dean/file level batching #10376
Open
Dean/file level batching #10376
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
dean-starkware
force-pushed
the
dean/file_level_batching
branch
4 times, most recently
from
f5578a9 to
553f337
Compare
dean-starkware
force-pushed
the
dean/file_level_batching
branch
from
553f337 to
d159a05
Compare
dean-starkware
force-pushed
the
dean/file_level_batching
branch
from
da95b09 to
94ade78
Compare
dean-starkware
force-pushed
the
dean/file_level_batching
branch
6 times, most recently
from
d5b2181 to
554ed58
Compare
Before: 1000 separate transactions (1000 commits = SLOW) After: 1 transaction with 1000 writes (1 commit = FAST!) Changes: - Separate batch items by type before writing - Open ONE transaction - Write all headers, state diffs, and casms - Commit ONCE - Post-process compiled classes (class manager) and base layer blocks This should reduce batch flush time from minutes to seconds!
dean-starkware
force-pushed
the
dean/file_level_batching
branch
3 times, most recently
from
30dae23 to
6df6488
Compare
dean-starkware
force-pushed
the
dean/file_level_batching
branch
from
6df6488 to
7aa671f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.