Skip to content

starknet_api: add proof facts to invoke v3 #10599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
avivg-starkware merged 1 commit into from
Dec 9, 2025
Merged

starknet_api: add proof facts to invoke v3 #10599

avivg-starkware merged 1 commit into from
Dec 9, 2025

Conversation

@avivg-starkware
Copy link
Contributor

@avivg-starkware avivg-starkware commented Dec 7, 2025

No description provided.

@reviewable-StarkWare
Copy link

reviewable-StarkWare commented Dec 7, 2025

This change is Reviewable

@avivg-starkware avivg-starkware marked this pull request as ready for review December 7, 2025 13:25
@github-actions
Copy link

github-actions bot commented Dec 7, 2025 •
edited
Loading

Artifacts upload workflows:

@avivg-starkware Graphite App
Copy link
Contributor Author

avivg-starkware commented Dec 7, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@avivg-starkware avivg-starkware force-pushed the avivg/starknet_api/add_poof_facts_to_invoke_v3 branch 10 times, most recently from 598fc87 to 4cd5263 Compare December 8, 2025 11:55
@avivg-starkware avivg-starkware mentioned this pull request Dec 8, 2025
Merged
meship-starkware
meship-starkware approved these changes Dec 8, 2025
View reviewed changes
Copy link
Collaborator

@meship-starkware meship-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@meship-starkware reviewed 1 of 6 files at r2, 13 of 13 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @noaov1)

meship-starkware
meship-starkware approved these changes Dec 8, 2025
View reviewed changes
Copy link
Collaborator

@meship-starkware meship-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @noaov1)

@avivg-starkware avivg-starkware mentioned this pull request Dec 8, 2025
Merged
@avivg-starkware avivg-starkware force-pushed the avivg/starknet_api/add_poof_facts_to_invoke_v3 branch 4 times, most recently from 5b42343 to ef9b207 Compare December 8, 2025 14:40
@avivg-starkware avivg-starkware force-pushed the avivg/starknet_api/add_poof_facts_to_invoke_v3 branch from ef9b207 to 93f986b Compare December 8, 2025 14:43
meship-starkware
meship-starkware reviewed Dec 9, 2025
View reviewed changes
Copy link
Collaborator

@meship-starkware meship-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@meship-starkware reviewed 9 of 10 files at r4, all commit messages.
Reviewable status: 13 of 14 files reviewed, all discussions resolved (waiting on @noaov1)

meship-starkware
meship-starkware approved these changes Dec 9, 2025
View reviewed changes
Copy link
Collaborator

@meship-starkware meship-starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@meship-starkware reviewed 1 of 10 files at r4.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @noaov1)

@avivg-starkware avivg-starkware added this pull request to the merge queue Dec 9, 2025
Merged via the queue into main with commit 8ab1314 Dec 9, 2025
46 of 51 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 10, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@meship-starkware meship-starkware meship-starkware approved these changes

@noaov1 noaov1 Awaiting requested review from noaov1

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@avivg-starkware @reviewable-StarkWare @meship-starkware