Skip to content

apollo_rpc: add proof_facts to invoke v3 #10629

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
avivg-starkware merged 1 commit into from
Dec 9, 2025
Merged

apollo_rpc: add proof_facts to invoke v3 #10629

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions crates/apollo_rpc/src/v0_8/api/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -619,6 +619,7 @@ impl From<InvokeTransaction> for starknet_api::transaction::InvokeTransaction {
account_deployment_data,
nonce_data_availability_mode,
fee_data_availability_mode,
proof_facts,
}) => Self::V3(starknet_api::transaction::InvokeTransactionV3 {
resource_bounds: resource_bounds.into(),
tip,
Expand All @@ -630,8 +631,7 @@ impl From<InvokeTransaction> for starknet_api::transaction::InvokeTransaction {
fee_data_availability_mode,
paymaster_data,
account_deployment_data,
// TODO(AvivG): Get proof facts from rpc_v8 once supported.
proof_facts: vec![],
proof_facts,
}),
}
}
Expand Down
5 changes: 3 additions & 2 deletions crates/apollo_rpc/src/v0_8/transaction.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -447,7 +447,7 @@ pub struct InvokeTransactionV3 {
pub account_deployment_data: AccountDeploymentData,
pub nonce_data_availability_mode: DataAvailabilityMode,
pub fee_data_availability_mode: DataAvailabilityMode,
// TODO(AvivG): Add proof facts to rpc_v8.
pub proof_facts: Vec<Felt>,
}

impl From<InvokeTransactionV3> for client_transaction::InvokeTransaction {
Expand Down Expand Up @@ -537,7 +537,7 @@ impl TryFrom<starknet_api::transaction::InvokeTransaction> for InvokeTransaction
fee_data_availability_mode,
paymaster_data,
account_deployment_data,
proof_facts: _,
proof_facts,
},
) => Ok(Self::Version3(InvokeTransactionV3 {
sender_address,
Expand All @@ -551,6 +551,7 @@ impl TryFrom<starknet_api::transaction::InvokeTransaction> for InvokeTransaction
fee_data_availability_mode,
paymaster_data,
account_deployment_data,
proof_facts,
})),
}
}
Expand Down
2 changes: 2 additions & 0 deletions crates/apollo_rpc/src/v0_8/transaction_test.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ use starknet_api::transaction::fields::{
};
use starknet_api::transaction::{L1HandlerTransaction, Transaction};
use starknet_api::{calldata, contract_address, felt, nonce};
use starknet_types_core::felt::Felt;

use super::super::transaction::{L1HandlerMsgHash, L1L2MsgHash};
use super::{
Expand Down Expand Up @@ -120,6 +121,7 @@ auto_impl_get_test_instance! {
pub account_deployment_data: AccountDeploymentData,
pub nonce_data_availability_mode: DataAvailabilityMode,
pub fee_data_availability_mode: DataAvailabilityMode,
pub proof_facts: Vec<Felt>,
}
pub enum TransactionVersion0 {
Version0 = 0,
Expand Down
Loading