starknet_committer: reorganize facts db files

[ArielElp]

No description provided.

[reviewable-StarkWare]

This change is 

[ArielElp]

• starknet_committer: add index db #10685
• starknet_committer: abstract original tree creation #10684
• starknet_committer,starknet_patricia: remove generic config #10683
• starknet_committer: add index layout nodes #10682
• starknet_committer: add index layout leaves #10681
• starknet_committer,starknet_committer_and_os_cli,starknet_patricia: make fetch_nodes layout dependent #10680
• starknet_committer,starknet_patricia: enrich subtree trait to support fetch nodes #10751
• starknet_committer,starknet_committer_and_os_cli,starknet_patricia: make FilledNode generic and introduce the FactsFilledNode alias #10750
• starknet_committer,starknet_os,starknet_patricia: make node data generic #10679
• starknet_committer,starknet_patricia: add deserialization context #10704
• starknet_committer,starknet_patricia,starknet_patricia_storage: add context to prefix and serde #10678
• starknet_committer,starknet_patricia: add subtree trait #10694
• starknet_committer: reorganize facts db files #10677 👈 (View in Graphite)
• main-v0.14.1-committer

This stack of pull requests is managed by Graphite. Learn more about stacking.

[nimrod-starkware]

@nimrod-starkware reviewed 7 of 14 files at r1, 7 of 7 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @yoavGrs)

[yoavGrs]

@yoavGrs reviewed 7 of 14 files at r1, 4 of 7 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @ArielElp)

---

crates/starknet_committer/src/db/facts_db/mod.rs line 2 at r2 (raw file):

pub mod create_facts_tree;
pub mod db;

I don't like the double db in the hierarchy of db.facts_db.db.
Rename to storage? WDYT?
If it breaks the entire stack, add a TODO, please.

Code quote:

pub mod db;

---

crates/starknet_committer/src/db/facts_db/traversal_test.rs line 35 at r2 (raw file):

use starknet_types_core::hash::Pedersen;

use crate::db::facts_db::traversal::fetch_patricia_paths_inner;

Why do you need it?

Code quote:

use crate::db::facts_db::traversal::fetch_patricia_paths_inner;

[ArielElp]

Reviewable status: 11 of 14 files reviewed, 2 unresolved discussions (waiting on @nimrod-starkware and @yoavGrs)

---

crates/starknet_committer/src/db/facts_db/mod.rs line 2 at r2 (raw file):

Previously, yoavGrs wrote…

I don't like the double db in the hierarchy of db.facts_db.db.
Rename to storage? WDYT?
If it breaks the entire stack, add a TODO, please.

Added a TODO. I prefer it to be in mod.rs directly rather than storage.

---

crates/starknet_committer/src/db/facts_db/traversal_test.rs line 35 at r2 (raw file):

Previously, yoavGrs wrote…

Why do you need it?

It's needed in the file, used to be:

use super::fetch_patricia_paths_inner

that I forgot to delete here, see now.

[yoavGrs]

@yoavGrs reviewed 3 of 3 files at r3, 5 of 5 files at r4, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @ArielElp)