apollo_rpc: add proof to invoke v3

[avivg-starkware]

No description provided.

[reviewable-StarkWare]

This change is 

[avivg-starkware]

• starknet_api: add proof to rpc_invoke_v3 #10713
• apollo_protobuf: add proof to invoke v3 #10711
• apollo_rpc: add proof to invoke v3 #10710 👈 (View in Graphite)
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

[avivg-starkware]

crates/apollo_test_utils/src/lib.rs line 2 at r2 (raw file):

#![allow(clippy::unwrap_used)]
#![recursion_limit = "256"]

alternative approach - adding its own get_test_instance

Code snippet:

impl GetTestInstance for Proof {
    fn get_test_instance(rng: &mut ChaCha8Rng) -> Self {
        Self(Arc::new(vec![rng.next_u32(), rng.next_u32(), rng.next_u32()]))
    }
}

[meship-starkware]

@meship-starkware reviewed 3 of 3 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @avivg-starkware and @noaov1)

---

crates/apollo_test_utils/src/lib.rs line 2 at r2 (raw file):

#![allow(clippy::unwrap_used)]
#![recursion_limit = "256"]

Why do we need the resource limit now?

Code quote:

#![recursion_limit = "256"]

[noaov1]

@noaov1 reviewed 3 of 3 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @avivg-starkware and @meship-starkware)

---

crates/apollo_test_utils/src/lib.rs line 2 at r2 (raw file):

Previously, meship-starkware (Meshi Peled) wrote…

Why do we need the resource limit now?

+1
How is it different from the calldata field?

---

crates/apollo_rpc/src/v0_8/transaction.rs line 558 at r2 (raw file):

                account_deployment_data,
                proof_facts,
                proof: Proof::default(),

What do you expect to put here?

Code quote:

                proof: Proof::default(),

---

crates/apollo_test_utils/src/lib.rs line 433 at r2 (raw file):

    pub struct AccountDeploymentData(pub Vec<Felt>);
    pub struct ProofFacts(pub Vec<Felt>);
    pub struct Proof(pub Arc<Vec<u32>>);

Please keep alphebetize :)

Code quote:

    pub struct ProofFacts(pub Vec<Felt>);
    pub struct Proof(pub Arc<Vec<u32>>);

[avivg-starkware]

Reviewable status: 2 of 4 files reviewed, 3 unresolved discussions (waiting on @meship-starkware and @noaov1)

---

crates/apollo_rpc/src/v0_8/transaction.rs line 558 at r2 (raw file):

Previously, noaov1 (Noa Oved) wrote…

What do you expect to put here?

My thinking is that this mainly affects tests, or, if it’s not test-related, that the info still isn’t needed here

• We don’t expect proof to appear in the blockifier's tx starknet_api::transaction::InvokeTransaction.

That said, I’m not fully convinced, so I added a TODO to investigate further.

---

crates/apollo_test_utils/src/lib.rs line 2 at r2 (raw file):

Previously, noaov1 (Noa Oved) wrote…

+1
How is it different from the calldata field?

The macro hit Rust’s recursion limit once Proof was added.
Calldata worked before because the total number of types was still under the 128-step recursion limit. I can change it to "129", which also works, or any other number.
Or to implement the separate GetTestInstance for Proof suggested above (but im tending to just make the recursion limit higher)

[noaov1]

@noaov1 reviewed 2 of 2 files at r3, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @meship-starkware)

[noaov1]

Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @avivg-starkware and @meship-starkware)

---

crates/apollo_test_utils/src/lib.rs line 2 at r2 (raw file):

Previously, avivg-starkware wrote…

The macro hit Rust’s recursion limit once Proof was added.
Calldata worked before because the total number of types was still under the 128-step recursion limit. I can change it to "129", which also works, or any other number.
Or to implement the separate GetTestInstance for Proof suggested above (but im tending to just make the recursion limit higher)

Why does the 128 step limit was not needed to be specified explicitly?
Is the new limitation just because you added one more field?

[avivg-starkware]

crates/apollo_test_utils/src/lib.rs line 2 at r2 (raw file):

Previously, noaov1 (Noa Oved) wrote…

Why does the 128 step limit was not needed to be specified explicitly?
Is the new limitation just because you added one more field?

Exactly, Rust has a macro expansion recursion limit, defaulting to 128.
I can add a comment above the limit expansion - do you think it'll be helpful?

[noaov1]

Reviewable status: complete! all files reviewed, all discussions resolved

---

crates/apollo_test_utils/src/lib.rs line 2 at r2 (raw file):

Previously, avivg-starkware wrote…

Exactly, Rust has a macro expansion recursion limit, defaulting to 128.
I can add a comment above the limit expansion - do you think it'll be helpful?

Yes. Thank you