Skip to content

apollo_storage: create storage_reader_server_test_utils #10835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nadin-Starkware merged 2 commits into from
Dec 17, 2025
Merged

apollo_storage: create storage_reader_server_test_utils #10835

nadin-Starkware merged 2 commits into from
Dec 17, 2025

Conversation

@nadin-Starkware
Copy link
Collaborator

@nadin-Starkware nadin-Starkware commented Dec 16, 2025

No description provided.

@reviewable-StarkWare
Copy link

reviewable-StarkWare commented Dec 16, 2025

This change is Reviewable

@github-actions
Copy link

github-actions bot commented Dec 16, 2025 •
edited
Loading

Artifacts upload workflows:

@nadin-Starkware Graphite App
Copy link
Collaborator Author

nadin-Starkware commented Dec 16, 2025 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

This was referenced Dec 16, 2025
Merged
Merged
@nadin-Starkware nadin-Starkware force-pushed the 12-16-apollo_storage_create_storage_reader_server_test_utils branch 2 times, most recently from e5bb1b0 to f5d06f6 Compare December 16, 2025 13:16
@nadin-Starkware nadin-Starkware force-pushed the 12-16-apollo_batcher_add_statediffbyblocknumber_request_to_the_batcher branch from 35d0856 to 5fb8364 Compare December 16, 2025 13:16
@nadin-Starkware nadin-Starkware force-pushed the 12-16-apollo_storage_create_storage_reader_server_test_utils branch from f5d06f6 to 13f3d52 Compare December 16, 2025 14:40
@nadin-Starkware nadin-Starkware force-pushed the 12-16-apollo_batcher_add_statediffbyblocknumber_request_to_the_batcher branch from 5fb8364 to ac86563 Compare December 16, 2025 14:40
Itay-Tsabary-Starkware
Itay-Tsabary-Starkware approved these changes Dec 16, 2025
View reviewed changes
Copy link
Contributor

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

I do expect this code to eventually become non-test-util as it will be used in the "client side", but let's leave as is for the time being

:lgtm:

@Itay-Tsabary-Starkware reviewed 4 of 4 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @nadin-Starkware)

@nadin-Starkware nadin-Starkware force-pushed the 12-16-apollo_batcher_add_statediffbyblocknumber_request_to_the_batcher branch from ac86563 to 5825888 Compare December 17, 2025 07:11
@nadin-Starkware nadin-Starkware force-pushed the 12-16-apollo_storage_create_storage_reader_server_test_utils branch 2 times, most recently from 9692db1 to c208d23 Compare December 17, 2025 07:43
@nadin-Starkware nadin-Starkware force-pushed the 12-16-apollo_batcher_add_statediffbyblocknumber_request_to_the_batcher branch 2 times, most recently from d9ec0e8 to d6e4326 Compare December 17, 2025 07:51
@nadin-Starkware nadin-Starkware force-pushed the 12-16-apollo_storage_create_storage_reader_server_test_utils branch from c208d23 to 0d25c50 Compare December 17, 2025 07:51
@nadin-Starkware nadin-Starkware force-pushed the 12-16-apollo_batcher_add_statediffbyblocknumber_request_to_the_batcher branch from d6e4326 to 64c147a Compare December 17, 2025 07:58
@nadin-Starkware nadin-Starkware force-pushed the 12-16-apollo_storage_create_storage_reader_server_test_utils branch from 0d25c50 to c29e5da Compare December 17, 2025 07:58
@nadin-Starkware nadin-Starkware force-pushed the 12-16-apollo_batcher_add_statediffbyblocknumber_request_to_the_batcher branch from 64c147a to d6927e2 Compare December 17, 2025 08:03
@nadin-Starkware nadin-Starkware force-pushed the 12-16-apollo_storage_create_storage_reader_server_test_utils branch 2 times, most recently from 5385afb to ff91add Compare December 17, 2025 08:18
@nadin-Starkware nadin-Starkware force-pushed the 12-16-apollo_batcher_add_statediffbyblocknumber_request_to_the_batcher branch 2 times, most recently from e63514d to c986f20 Compare December 17, 2025 08:31
@nadin-Starkware nadin-Starkware force-pushed the 12-16-apollo_storage_create_storage_reader_server_test_utils branch from ff91add to 3be405d Compare December 17, 2025 08:31
@nadin-Starkware nadin-Starkware force-pushed the 12-16-apollo_batcher_add_statediffbyblocknumber_request_to_the_batcher branch from c986f20 to d963c1c Compare December 17, 2025 08:34
@nadin-Starkware nadin-Starkware force-pushed the 12-16-apollo_storage_create_storage_reader_server_test_utils branch from 3be405d to d070bf4 Compare December 17, 2025 08:34
@graphite-app graphite-app bot changed the base branch from 12-16-apollo_batcher_add_statediffbyblocknumber_request_to_the_batcher to main-v0.14.1 December 17, 2025 09:35
nadin-Starkware
nadin-Starkware commented Dec 17, 2025
View reviewed changes
Copy link
Collaborator Author

@nadin-Starkware nadin-Starkware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nadin-Starkware reviewed 4 of 4 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @nadin-Starkware)

@nadin-Starkware nadin-Starkware added this pull request to the merge queue Dec 17, 2025
Merged via the queue into main-v0.14.1 with commit 10d53ba Dec 17, 2025
23 of 31 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Dec 19, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Itay-Tsabary-Starkware Itay-Tsabary-Starkware Itay-Tsabary-Starkware approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nadin-Starkware @reviewable-StarkWare @Itay-Tsabary-Starkware