fix(ens): fix double status ens name added by accident to DB #19244
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jrainville
requested review from
igor-sirotin,
iurimatias and
osmaczko
and removed request for
a team
Member
Jenkins BuildsClick to see older builds (14)
|
igor-sirotin
approved these changes
Nov 12, 2025
osmaczko
approved these changes
Nov 12, 2025
micieslak
approved these changes
Nov 12, 2025
jrainville
force-pushed
the
fix/ens-name-double-domain
branch
from
e65837a to
f109d3d
Compare
Fixes #18619 The issue was simply that we added the ens domain to the name without checking if it was already there. Easily fixed by calling the utils function. Also, fixes past issues by calling a migration.
jrainville
force-pushed
the
fix/ens-name-double-domain
branch
from
f109d3d to
fdf62fd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do
Fixes #18619
status-go PR: status-im/status-go#7096
The issue was simply that we added the ens domain to the name without checking if it was already there. Easily fixed by calling the utils function.
Also, fixes past issues by calling a migration.
Affected areas
Architecture compliance
My PR is consistent with this document: QML Architecture Guidelines
Screencapture of the functionality
Impact on end user
Fixes the issue for new buys and old ones
How to test
Risk
Low