Update for latest libraries #163
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
need `moduleResolution: "nodenext"` in tsconfig to allow importing from `/contract` entrypoint (this is why types weren't being calculated correctly)
the type checking in `next build` mistakenly thinks that we set `target` to something older than `es2020`, so we need the `BigInt(10)` instead of `10n` ¯\_(ツ)_/¯
Contributor
Author
|
@Shaptic will you be able to review soon? |
leighmcculloch
approved these changes
Jul 16, 2024
Member
leighmcculloch
left a comment
leighmcculloch
left a comment
There was a problem hiding this comment.
One suggestion, but lgtm.
|
|
||
| [alias] # command aliases | ||
| install_soroban = "install --git https://github.com/AhaLabs/soroban-tools --rev c7fb7e08ba8efa9828d9df863d991558f269e35b --root ./target soroban-cli --debug" | ||
| install_stellar = "install --locked stellar-cli --version 21.0.0 --force --root ./target stellar-cli --debug" |
Member
There was a problem hiding this comment.
We can probably pin to a major version with ^21 instead of pinning to a specific version.
I also don't think we need to set the root, or tell cargo to install with the dev profile with the debug flag.
Suggested change
| install_stellar = "install --locked stellar-cli --version 21.0.0 --force --root ./target stellar-cli --debug" | |
| install_stellar = "install --locked stellar-cli@^21 --force" |
Member
There was a problem hiding this comment.
Ah ok I see the root is used to write the binary to a local directory then use it locally. Seems like an odd practice to encourage given it isn't encouraged in any other setup documentation though.
This was referenced Jul 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #150
It works again!