fix: properly handle name conflicts in WDL documents.#554
Merged
peterhuene merged 4 commits intostjude-rust-labs:mainfrom Jan 21, 2026
Merged
fix: properly handle name conflicts in WDL documents.#554peterhuene merged 4 commits intostjude-rust-labs:mainfrom
peterhuene merged 4 commits intostjude-rust-labs:mainfrom
Conversation
The WDL spec requires that names within a document's "namespace" be unique. Previously, tasks would check for conflicting workflow names, workflows would check for conflicting task names, and custom types would check for conflicting custom type names. With this fix, it is now an error to define a task or workflow that conflicts with a custom type name and vice versa. Update a few incorrect tests to show the new error. Fixes stjude-rust-labs#507.
Contributor
Author
|
@a-frantz if we want to fix the name in |
Member
|
a-frantz
approved these changes
Jan 21, 2026
a-frantz
approved these changes
Jan 21, 2026
Mahathi-s154
pushed a commit
to Mahathi-s154/sprocket
that referenced
this pull request
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The WDL spec requires that names within a document's "namespace" be unique.
Previously, tasks would check for conflicting workflow names, workflows would check for conflicting task names, and custom types would check for conflicting custom type names.
With this fix, it is now an error to define a task or workflow that conflicts with a custom type name and vice versa.
Update a few incorrect tests to show the new error.
Fixes #507.
Before submitting this PR, please make sure:
For external contributors:
For all contributors:
nextbranch in the sprocket.bio repository [if you are a Sprocket team member] or (b) have suggested any changes you think need to be made to sprocket.bio in the description of your PR [if you are an external contributor].For PRs containing lint rule changes:
RULES.md.crates/wdl-lint/tests/lintsthat covers everypossible diagnostic emitted for the rule within the file where the rule
is implemented.