Skip to content

fix: properly handle name conflicts in WDL documents.#554

Merged
peterhuene merged 4 commits intostjude-rust-labs:mainfrom
peterhuene:fix-names
Jan 21, 2026
Merged

fix: properly handle name conflicts in WDL documents.#554
peterhuene merged 4 commits intostjude-rust-labs:mainfrom
peterhuene:fix-names

Conversation

@peterhuene
Copy link
Copy Markdown
Contributor

@peterhuene peterhuene commented Jan 21, 2026

The WDL spec requires that names within a document's "namespace" be unique.

Previously, tasks would check for conflicting workflow names, workflows would check for conflicting task names, and custom types would check for conflicting custom type names.

With this fix, it is now an error to define a task or workflow that conflicts with a custom type name and vice versa.

Update a few incorrect tests to show the new error.

Fixes #507.

Before submitting this PR, please make sure:

For external contributors:

  • You have read the contributing guide in its entirety.
  • You have not used AI on any parts of this pull request.

For all contributors:

  • You have added a few sentences describing the PR here.
  • You have added yourself or the appropriate individual as the assignee.
  • You have added at least one relevant code reviewer to the PR.
  • Your code builds clean without any errors or warnings.
  • You have added tests (when appropriate).
  • You have added an entry in the CHANGELOG (when appropriate).
  • You have updated the README or other documentation to account for these changes (when appropriate).
  • You have either (a) made a PR to the next branch in the sprocket.bio repository [if you are a Sprocket team member] or (b) have suggested any changes you think need to be made to sprocket.bio in the description of your PR [if you are an external contributor].

For PRs containing lint rule changes:

  • You have updated any and all effected entries within RULES.md.
  • You have added a test case in crates/wdl-lint/tests/lints that covers every
    possible diagnostic emitted for the rule within the file where the rule
    is implemented.

The WDL spec requires that names within a document's "namespace" be unique.

Previously, tasks would check for conflicting workflow names, workflows would
check for conflicting task names, and custom types would check for conflicting
custom type names.

With this fix, it is now an error to define a task or workflow that conflicts
with a custom type name and vice versa.

Update a few incorrect tests to show the new error.

Fixes stjude-rust-labs#507.
@peterhuene peterhuene self-assigned this Jan 21, 2026
@peterhuene peterhuene requested a review from a team as a code owner January 21, 2026 18:19
@peterhuene peterhuene requested a review from a-frantz January 21, 2026 18:19
@peterhuene
Copy link
Copy Markdown
Contributor Author

@a-frantz if we want to fix the name in workflows first, I'll revert the update to the gauntlet baseline.

@a-frantz
Copy link
Copy Markdown
Member

@a-frantz if we want to fix the name in workflows first, I'll revert the update to the gauntlet baseline.

stjudecloud/workflows#292

@github-actions github-actions Bot added the S-awaiting-pass-CI PR is awaiting CI to pass. label Jan 21, 2026
@peterhuene peterhuene removed the S-awaiting-pass-CI PR is awaiting CI to pass. label Jan 21, 2026
@peterhuene peterhuene merged commit 68c88b2 into stjude-rust-labs:main Jan 21, 2026
20 checks passed
@peterhuene peterhuene deleted the fix-names branch January 21, 2026 20:49
Mahathi-s154 pushed a commit to Mahathi-s154/sprocket that referenced this pull request Mar 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix name conflict checks.

2 participants