feat: update GIF embed detection from Tenor to Giphy URLs#996
Closed
sanasol wants to merge 1 commit into
Closed
Conversation
Signed-off-by: sanasol <mail@sanasol.ws>
This was referenced Mar 4, 2026
Contributor
|
Interestingly for me, Giphy URLs already work with embeds exactly as Tenor GIFs do. I think it might be because it's passing this first check |
Member
|
The gifbox backend is not moving to giphy, unsure where that notion came from. |
Contributor
Author
|
@IAmTomahawkx sorry for misleading, it should come together with stoatchat/stoatchat#661 |
Contributor
|
I suppose for now we should close this then, until the alternative that Zomatree mentioned is ready to be switched to. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates GIF embed detection to match Giphy URLs instead of Tenor URLs, since the gifbox backend is migrating from Tenor to Giphy.
Changes
https://tenor.com→https://giphy.comin:Embed.tsx(embed component GIF detection)Message.tsx(inline GIF message detection)Related: stoatchat/stoatchat#661, stoatchat/for-android#94
Tested and live on https://chat.sanhost.net