-
Notifications
You must be signed in to change notification settings - Fork 2
Prefactor bugfix #70
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prefactor bugfix #70
Conversation
|
✅ Linter reported no issues All Python files are correctly formatted with Black. |
|
✅ Linter reported no issues All C/C++ files are correctly formatted with clang-format. |
|
In general the prefactor I do not like, we are putting a lot of interface pressure in multiplying by a constant. As we just saw, this functionality, which realistically spares the launching of a near-instant kernel, is bug inducing more than anything -.- |
…s to support this due to not using default lanczos
90e8678 to
73b6b23
Compare
cf87bab to
351736b
Compare
This is changing sqrtMdotW to respect the prefactor argument since it was ignoring it before.
To test it, I'm generating the same random samples by seeding libMobility and making sure they match with/without the prefactor. This way of testing now works for all solvers except PSE, which will require deeper changes in UAMMD. As far as I can tell, PSE pulls its seeds from the System module in UAMMD (e.g. here), which is currently seeded randomly (and amusingly).
Two questions for you @RaulPPelaez :