fix(access): ensure symlinks are followed when checking for executable flag#1253
Open
boneskull wants to merge 1 commit intostreamich:masterfrom
Open
fix(access): ensure symlinks are followed when checking for executable flag#1253boneskull wants to merge 1 commit intostreamich:masterfrom
boneskull wants to merge 1 commit intostreamich:masterfrom
Conversation
…e flag This is a one-line change in `volume.ts` which always resolves paths in the inner `_access` implementation. The result is that executable symlinks are now detected properly by `access()`, `accessSync()` and `promises.access()`. Added test suites for each of APIs asserting as much. Fixes streamich#1252
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a one-line change in
volume.tswhich always resolves paths in the inner_accessimplementation.The result is that executable symlinks are now detected properly by
access(),accessSync()andpromises.access().Added test suites for each of APIs asserting as much.
Fixes #1252