This repository was archived by the owner on Dec 14, 2022. It is now read-only.
Open
Conversation
syhily
reviewed
Feb 10, 2022
pulsar-flink-connector/pom.xml
Outdated
| <groupId>javax.xml.bind</groupId> | ||
| <artifactId>jaxb-api</artifactId> | ||
| <version>${jaxb.version}</version> | ||
| </dependency> |
Contributor
Author
There was a problem hiding this comment.
The JAXB APIs are considered to be Java EE APIs and therefore are no longer contained on the default classpath in Java SE 9. In Java 11, they are completely removed from the JDK.
Without this dependency, maven will report class not found issue for: https://github.com/streamnative/pulsar-flink/blob/master/pulsar-flink-connector/src/main/java/org/apache/flink/streaming/connectors/pulsar/internal/DateTimeUtils.java#L23
Contributor
There was a problem hiding this comment.
DatatypeConverter could be dropped. I don't like one method dependency jar.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Due to the CVE:
https://nvd.nist.gov/vuln/detail/CVE-2021-22569
Reference the fix in Apache Pulsar:
apache/pulsar#13695
Note:
I also tried to update the protobuf plugin (com.github.os72:protoc-jar-maven-plugin), but there's no newer release other than 3.11.4 at this time. https://mvnrepository.com/artifact/com.github.os72/protoc-jar-maven-plugin