Skip to content

fix(spec_object_parser): handle SPEC-OBJECT with no <VALUES> element #213

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stanislaw merged 1 commit into from
May 5, 2026
Merged

fix(spec_object_parser): handle SPEC-OBJECT with no <VALUES> element #213

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions reqif/parsers/spec_object_parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,14 +32,10 @@ def parse(spec_object_xml) -> ReqIFSpecObject:
)

xml_spec_values = spec_object_xml.find("VALUES")
attributes: Optional[List[SpecObjectAttribute]] = (
AttributeValueParser.parse_attribute_values(xml_spec_values)
attributes: List[SpecObjectAttribute] = (
AttributeValueParser.parse_attribute_values(xml_spec_values) or []
)

# FIXME: Technically, we can get a ReqIF file where VALUES is empty.
# But don't want to break the interfaces for now.
assert attributes is not None

return ReqIFSpecObject(
xml_node=spec_object_xml,
description=spec_object_description,
Expand Down
16 changes: 16 additions & 0 deletions tests/unit/reqif/parsers/test_spec_object_parser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,22 @@ def test_01_nominal_case():
assert spec_object.attribute_map["TEST_FIELD_STATEMENT"].value == "Test statement"


def test_03_missing_values_element():
"""ReqIF-1.2 §10.8.36/§10.8.40: <VALUES/> is optional; omitting it must not raise."""
spec_object_string = """
<SPEC-OBJECT IDENTIFIER="TEST_NO_VALUES_ID" LAST-CHANGE="2021-10-15T11:32:40.205+02:00">
<TYPE>
<SPEC-OBJECT-TYPE-REF>TEST_SPEC_OBJECT_TYPE</SPEC-OBJECT-TYPE-REF>
</TYPE>
</SPEC-OBJECT>
"""

spec_object_xml = etree.fromstring(spec_object_string)
spec_object = SpecObjectParser.parse(spec_object_xml)
assert spec_object.identifier == "TEST_NO_VALUES_ID"
assert spec_object.attributes == []


def test_02_attributes_xhtml():
spec_object_string = """\
<SPEC-OBJECT xmlns:reqif-xhtml="http://www.w3.org/1999/xhtml" IDENTIFIER="TEST_SPEC_OBJECT_ID" LAST-CHANGE="2021-10-15T11:32:40.205+02:00">
Expand Down
Loading