feat(backend/sdoc): ensure a more consistent handling of the meta vs content decision#2810
Merged
Merged
Conversation
…content decision WHAT: With this change, the reserved single-line fields, SingleChoice, MultipleChoice, and Tag, are always treated as single-line regardless of where they are declared in the SDoc grammar. WHY: Several users reported bugs caused by the previous behavior, specifically the documented but non-intuitive rule that used a content field (STATEMENT, CONTENT, or DESCRIPTION) as the boundary for deciding whether a field is single-line (before content) or multiline (after content). Closes #1900 Closes #2224 Closes #2758 Closes #2760 Closes #2765 Closes #2804
stanislaw
force-pushed
the
stanislav/single_vs_multiline
branch
from
6a10ba5 to
b8821d1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHAT: With this change, the reserved single-line fields, SingleChoice, MultipleChoice, and Tag, are always treated as single-line regardless of where they are declared in the SDoc grammar.
WHY: Several users reported bugs caused by the previous behavior, specifically the documented but non-intuitive rule that used a content field (STATEMENT, CONTENT, or DESCRIPTION) as the boundary for deciding whether a field is single-line (before content) or multiline (after content).
Closes #1900
Closes #2224
Closes #2758
Closes #2760
Closes #2765
Closes #2804