Skip to content

Fix constraint conflict in LinkEmailElement #5822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 13, 2025
+2 −2
Merged

Fix constraint conflict in LinkEmailElement #5822

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion Example/PaymentSheet Example/PaymentSheet Example/AppDelegate+BrokenConstraints.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,6 @@ extension AppDelegate {
// Ignore broken constraints that existed at the time of writing this - please try to fix newly introduced ones instead of ignoring!
// Sometimes the broken constraint references something that is unique, in which case we can ignore it easily
let ignoredBrokenConstraints = [
"STP_Internal_LinkMoreInfoView", // https://jira.corp.stripe.com/browse/RUN_MOBILESDK-4562
"verticalSeparatorWidth' separator|.width == 0.333333", // Apple broken UIAlert constraint - oddly they never log this either; maybe they also have an ignorelist!
"UISV-spacing' H:[_UIInterfaceActionCustomViewRepresentationView:", // Same as ^
"_UIModernBarButton:", // iOS 26+ keyboard toolbar issue
Expand Down
3 changes: 2 additions & 1 deletion StripePaymentSheet/StripePaymentSheet/Source/Internal/Link/Elements/LinkEmailElement.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,9 @@ class LinkEmailElement: Element {
trailing: theme.textFieldInsets.trailing
)
if let infoView = infoView {
// Use stack view's custom spacing instead of manual constraints to avoid conflicts
stackView.setCustomSpacing(ElementsUI.contentViewInsets.trailing, after: activityIndicator)
NSLayoutConstraint.activate([
activityIndicator.trailingAnchor.constraint(equalTo: infoView.leadingAnchor, constant: -ElementsUI.contentViewInsets.trailing),
infoView.widthAnchor.constraint(equalToConstant: LinkMoreInfoView.Constants.logoWidth),
])
}
Expand Down
Loading