fix: Remove default for minSize in platform buttons#481
Merged
aqwert merged 4 commits intostryder-dev:masterfrom Jan 14, 2026
Merged
fix: Remove default for minSize in platform buttons#481aqwert merged 4 commits intostryder-dev:masterfrom
aqwert merged 4 commits intostryder-dev:masterfrom
Conversation
|
@aqwert Can you please approve and deploy this fix? Thanks |
aqwert
approved these changes
Jan 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since minSize is deprecated it's no longer necessary to add a default for this. The default has to be removed anyway, otherwise the new value
minimumSizecannot be set. There is an assert in the CupertinoButton that only allows one of the two values.The assert:
assert(minimumSize == null || minSize == null)Without my changes, there is an exception if we try to use minimumSize. It's the same for other buttons.
Example: