Open
Conversation
EpsilonPrime
approved these changes
Jul 26, 2024
Contributor
Author
|
Wow, it took 90m to build on macos ??? |
Member
|
It looked like it built and then stalled waiting for the cleanup to happpen
(between steps).
…On Fri, Jul 26, 2024, 10:12 Jacques Nadeau ***@***.***> wrote:
Wow, it took 90m to build on macos
???
—
Reply to this email directly, view it on GitHub
<#106 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABDDCFDTSQIOE4Z5MPRXCTZOJ7QTAVCNFSM6AAAAABLPRMJZ6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDENJTGE3DGMBXGQ>
.
You are receiving this because you commented.Message ID:
***@***.***>
|
Member
|
It is odd that the required "build" option is still pending and that build was renamed to linux-build. I don't see an option to change the required builds in the repo though. |
Contributor
Author
|
Running again to see if performance continues to be bad.
That's something configured inside the Github UI afaik. I changed the names to be clearer around steps but would need to change at the repo level as well if we decide to merge this. Will wait to see if perf was a random problem or constant. If constant I'm inclined to shelve this for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.