🐛(backend) enforce emoji validation for reactions#1965
Open
maboukerfa wants to merge 1 commit intosuitenumerique:mainfrom
Open
🐛(backend) enforce emoji validation for reactions#1965maboukerfa wants to merge 1 commit intosuitenumerique:mainfrom
maboukerfa wants to merge 1 commit intosuitenumerique:mainfrom
Conversation
maboukerfa
force-pushed
the
fix/enforce_emoji
branch
from
d709426 to
f2b1da9
Compare
lunika
reviewed
Mar 11, 2026
Member
lunika
left a comment
lunika
left a comment
There was a problem hiding this comment.
Thanks a lot for your contribution.
Just one comment, and it will be good.
|
|
||
| def validate_emoji(self, value): | ||
| """Ensure the reaction is a single emoji.""" | ||
| if not emoji.is_emoji(value): |
Member
There was a problem hiding this comment.
Can you please add a warning log here? To ensure that valid emoji are not rejected?
Contributor
Author
There was a problem hiding this comment.
I added a warning log to for the rejected emojis and their corresponding Unicode
Validate emojis in ReactionSerializer (previously accepted any string), preventing multiple emojis or text uploads in a single reaction Signed-off-by: Mohamed El Amine BOUKERFA <boukerfa.ma@gmail.com>
maboukerfa
force-pushed
the
fix/enforce_emoji
branch
from
f2b1da9 to
ca38eaa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request enforces emoji validation in the
ReactionSerializerto prevent invalid emoji submissions.Proposal
ReactionSerializer(previously accepted any string)