Skip to content

🐛(frontend) fix leftpanel button in doc version#2089

Merged
AntoLC merged 1 commit intomainfrom
fix/version-remove-close-panel
Mar 23, 2026
Merged

🐛(frontend) fix leftpanel button in doc version#2089
AntoLC merged 1 commit intomainfrom
fix/version-remove-close-panel

Conversation

@AntoLC
Copy link
Collaborator

@AntoLC AntoLC commented Mar 19, 2026

Purpose

The left panel button was shown in the doc version page.
This commit removes the button from the doc version page by moving it to the DocLayout.
By moving it to the DocLayout, we do not have the flickering when we switch between subpages.

Demo problem

image

@AntoLC AntoLC self-assigned this Mar 19, 2026
@AntoLC AntoLC mentioned this pull request Mar 19, 2026
@AntoLC AntoLC requested a review from Ovgodd March 19, 2026 15:42
@github-actions
Copy link

github-actions bot commented Mar 19, 2026

Size Change: -54 B (0%)

Total Size: 4.23 MB

Filename Size Change
apps/impress/out/_next/static/5803d3a0/_buildManifest.js 904 B +904 B (new file) 🆕
apps/impress/out/_next/static/d780c58b/_buildManifest.js 0 B -904 B (removed) 🏆

compressed-size-action

@AntoLC AntoLC force-pushed the fix/version-remove-close-panel branch 3 times, most recently from 286a119 to 8e29be2 Compare March 20, 2026 10:41
Copy link
Collaborator

@Ovgodd Ovgodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ouh nice catch

The left panel button was shown in the doc version page.
This commit removes the button from the doc version
page by moving it to the DocLayout.
By moving it to the DocLayout, we do not have the
flickering when we switch between subpages.
@AntoLC AntoLC force-pushed the fix/version-remove-close-panel branch from 8e29be2 to a432636 Compare March 23, 2026 09:33
@AntoLC AntoLC merged commit a432636 into main Mar 23, 2026
26 of 27 checks passed
@AntoLC AntoLC deleted the fix/version-remove-close-panel branch March 23, 2026 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants