fix(FiniteStateMachine): only emit console warnings in dev mode#412
Open
bxff wants to merge 1 commit intosvecosystem:mainfrom
Open
fix(FiniteStateMachine): only emit console warnings in dev mode#412bxff wants to merge 1 commit intosvecosystem:mainfrom
bxff wants to merge 1 commit intosvecosystem:mainfrom
Conversation
Wrap both console.warn calls in #dispatch with DEV guards from esm-env so they are tree-shaken out of production builds. Closes svecosystem#370
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
FiniteStateMachinewarns on invalid events and invalid lifecycle metadata, which is helpful during development but shouldn't show up in production. This wraps bothconsole.warncalls in#dispatchwithDEVfromesm-envso they get tree-shaken out of production builds.Closes #370