Add lastfm client bundle 2.0 #1884
Closed
+29
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add recipe for calliostro/last-fm-client-bundle v2.0 - Updates configuration key from calliostro_last_fm_client to calliostro_lastfm - Changes api_key and secret configuration structure - Adds optional user_agent and rate_limiter configuration - Removes session key from environment variables (deprecated) - Symfony bundle for Last.fm API integration
- Add missing newlines at end of files - Ensure YAML uses 4-space indentation - Fix Symfony recipes coding standards compliance
- Remove 4 spaces from empty lines (lines 4, 7, 10) - Empty lines must be completely empty per Symfony standards - Fixes GitHub Actions indentation check
- Update bundle class from CalliostroLastFmClientBundle to CalliostroLastfmBundle - Update namespace from LastFmClientBundle to LastfmBundle - Matches actual bundle class in v2.0.0-beta.1
- Move config file to packages/ directory for modern bundle standards - Add session_key configuration option for authenticated operations
There was a problem hiding this comment.
Pull Request Overview
This PR adds a Symfony Flex recipe for calliostro/lastfm-bundle version 2.0, introducing configuration enhancements and structural updates to align with modern Symfony best practices.
Key Changes:
- Relocates configuration files from
config/toconfig/packages/directory - Updates bundle namespace from
CalliostroLastFmClientBundletoCalliostroLastfmBundle - Adds optional
session_keyconfiguration for authenticated operations (scrobbling, user operations)
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
calliostro/last-fm-client-bundle/2.0/manifest.json |
Defines bundle registration with updated namespace, configures file installation to packages/ directory, and declares environment variables including optional LASTFM_SESSION |
calliostro/last-fm-client-bundle/2.0/config/packages/calliostro_lastfm.yaml |
Provides configuration template with required API credentials, optional session key for authenticated operations, and additional optional settings for user agent and rate limiting |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # Required: API Key for all practical operations (get from https://www.last.fm/api/account/create) | ||
| api_key: '%env(LASTFM_API_KEY)%' | ||
|
|
||
| # Required for authenticated operations: API Secret |
There was a problem hiding this comment.
Trailing whitespace detected after "API Secret". This should be removed to maintain code cleanliness.
Suggested change
| # Required for authenticated operations: API Secret | |
| # Required for authenticated operations: API Secret |
Contributor
Author
|
Closing this PR as the recipe was already added in #1881. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a recipe for
calliostro/lastfm-bundleversion 2.0.Changes
packages/directoryLASTFM_SESSIONenvironment variablesession_keyconfiguration option