Merge hotfix changes from v0.7.0-rc.26 back to main#57
Open
Conversation
PeerStore::add_peer previously returned early if a peer already existed, silently discarding address updates. When an LSP node's IP changed, the reconnection loop would indefinitely retry the stale cached address. This commit: 1. Changes add_peer to upsert: if the peer exists but the address differs, update and re-persist it. 2. Reorders Node::connect to persist the peer *before* attempting the connection, so the new address is saved even if the connection races with an in-flight reconnection attempt at the old address. 3. Adds unit tests for the upsert logic and an integration test for persist-on-failed-connect. See upstream issue lightningdevkit#700. Co-authored-by: Cursor <cursoragent@cursor.com>
fix: upsert peer address on connect
The JVM groupId was still hardcoded to org.lightningdevkit while Android correctly used com.synonym. This aligns both by reading group from gradle.properties, matching the Android pattern. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
…size fix: switch Kotlin publishing to GitHub Packages
Collaborator
Author
Merge ConflictsThis PR has conflicts in version-related and binary files, which is expected since both branches had independent version bumps: Text conflicts (version strings):
Binary conflicts (compiled bindings):
Resolution plan: The key changes (peer address upsert fix, test rename, minSdk bump) merge cleanly. The version/binary conflicts should be resolved by keeping |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PeerStore::add_peernow updates the stored socket address when a peer reconnects with a different IP, instead of silently ignoring it. Includes unit + integration tests.peer_address_updated_on_readd→peer_address_updated_on_re_addcom.synonymgroupId (already onmain, should auto-resolve)Test plan
🤖 Generated with Claude Code