Brush extents fire events fix#338
Open
Git-me-outta-here wants to merge 2 commits into
Open
Conversation
update to master
…t. This prevents calls to 'brushend' with incomplete brushings (example: brushExtents updates extent on dimension 1, calls 'brushend' with wrong __.brushed b/c dimension 2 does not have a brush extent yet; then updates extent on dimension 2, calls 'brushend' again, this time with correct __.brushed)
Collaborator
Author
|
I guess this could be improved. In fact this should only send a single event, not one per dimension. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brushExtents now fires events only after all new extents have been set. This prevents calls to 'brushend' with incomplete brushings.
Example:
brushExtents updates extent on dimension 1, calls 'brushend' with wrong __.brushed b/c dimension 2 does not have a brush extent yet;
then updates extent on dimension 2, calls 'brushend' again, this time with correct __.brushed