feature: pass ModRevision field from kv.KeyValue structure to integrity.ValidatedResult #36
+26
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bigbes
reviewed
Dec 23, 2025
bigbes
reviewed
Dec 23, 2025
Mockird31
force-pushed
the
mockird31/gh-23-extend-validated-result
branch
from
9cf31b8 to
9488c97
Compare
bigbes
reviewed
Dec 23, 2025
integrity/typed_test.go
Outdated
| namedValue, err := typed.Get(ctx, "my-object") | ||
| require.NoError(t, err) | ||
| assert.Equal(t, "my-object", namedValue.Name) | ||
| assert.Equal(t, int64(0), namedValue.ModRevision) |
Collaborator
There was a problem hiding this comment.
Same pls, add ModRevision checks with predefined in expectedKVs here.
Collaborator
There was a problem hiding this comment.
Still checking modRevision for zero value, you need to check it for predefined in expectedKVs value.
bigbes
reviewed
Dec 23, 2025
Mockird31
force-pushed
the
mockird31/gh-23-extend-validated-result
branch
from
9488c97 to
adf3108
Compare
Added ModRevision field to integrity.ValidatedResult. Tests have been supplemented with ModRevision checks. Closes #23
Mockird31
force-pushed
the
mockird31/gh-23-extend-validated-result
branch
from
adf3108 to
f621c6a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
feature: pass ModRevision field from kv.KeyValue structure to integrity.ValidatedResult
Added ModRevision field to integrity.ValidatedResult. Tests have been supplemented with ModRevision checks.
Closes #23