update Buttons relays switches description#1215
Open
ouinouin wants to merge 2 commits intotasmota:masterfrom
Open
update Buttons relays switches description#1215ouinouin wants to merge 2 commits intotasmota:masterfrom
ouinouin wants to merge 2 commits intotasmota:masterfrom
Conversation
For the ESP_32 section, the relays switches buttons descritpion was incomplete, added descrption for _d (pulldown) _i (inverted active high) , _n (no pullup) taking reference the related esp8266 peripheral section when possible. did vertical bar separator cosmetic realignment on markdown source. (hence changed lines nr.)
barbudor
requested changes
Apr 13, 2023
Collaborator
barbudor
left a comment
barbudor
left a comment
There was a problem hiding this comment.
Thanks for your contribution
Please review my comments
swapped the active high and active low according to @barbudor comments.
Contributor
|
@ouinouin, please look at the review suggestions and implement them! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the ESP_32 section, the relays switches buttons descritpion was incomplete, added descrption for _d (pulldown) _i (inverted active high) , _n (no pullup) taking reference the related esp8266 peripheral section when possible. did vertical bar separator cosmetic realignment on markdown source. (hence changed lines nr.)