Skip to content

Conversation

@ctcpip
Copy link
Member

@ctcpip ctcpip commented Jul 21, 2025

eliminate duplicate runs on PRs

eliminate duplicate runs on PRs
@ctcpip ctcpip requested a review from ljharb July 21, 2025 16:51
@ljharb
Copy link
Member

ljharb commented Jul 21, 2025

I'd left it this way intentionally, since it's not a given that a pushed branch will immediately be turned into a PR. The runs are also parallelized, so this won't make full runs any faster, it'll just save github some money.

@michaelficarra
Copy link
Member

Do people look at actions status for commits that aren't part of some PR? I'd think this would be a waste somewhere between 99% and 100% of the time.

@ljharb
Copy link
Member

ljharb commented Jul 21, 2025

I do, but either way it's only a waste for github ¯\_(ツ)_/¯

@ctcpip
Copy link
Member Author

ctcpip commented Jul 21, 2025

it's not a given that a pushed branch will immediately be turned into a PR

do we really care about pushed non-default branches running CI right away? either they will get a PR, or they will get merged to main without a PR and if that happens, it's likely nobody was looking at the CI result anyway

it's not a big deal either way, but I have my preference 😄

@ljharb
Copy link
Member

ljharb commented Jul 21, 2025

Most of the time, no, we won't care - but this PR won't improve anything for anyone either, except GitHub :-)

@michaelficarra
Copy link
Member

I'm okay with improving things for GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants