Normative: Remove spurious/unnecessary check for "out of range" era #89
Conversation
years from `NonISOCalendarDateToISO`, since "out of range" values for eras are fine. See: tc39#87 (comment)
| </dd> | ||
| </dl> | ||
| <emu-alg> | ||
| 1. Let _era_ be CanonicalizeEraInCalendar(_calendar_, _era_). |
There was a problem hiding this comment.
issue: I think this part is still necessary?
There was a problem hiding this comment.
_era_ is not used outside the removed AO. Canonicalization still happens in CalendarDateArithmeticYearForEraYear
(unless I'm misreading something here...)
There was a problem hiding this comment.
Oh, I see! Yeah that's fine then.
There was a problem hiding this comment.
CalendarDateArithmeticYearForEraYear expects CanonicalizeEraInCalendar returns a non-undefined value. This is no longer the case when IsValidEraYearForCalendar is removed altogether.
| </dd> | ||
| </dl> | ||
| <emu-alg> | ||
| 1. Let _era_ be CanonicalizeEraInCalendar(_calendar_, _era_). |
There was a problem hiding this comment.
CalendarDateArithmeticYearForEraYear expects CanonicalizeEraInCalendar returns a non-undefined value. This is no longer the case when IsValidEraYearForCalendar is removed altogether.
3 participants
Removed a check for era year range validity from
NonISOCalendarDateToISO, since "out of range" values for eras are fine. Allows for removal ofIsValidEraYearForCalendarAO altogether, sinceNonISOCalendarDateToISOonly place it was called from.fix #87
See: #87 (comment)