Fetch objects from /add objects to a given PDFGroup#410
Open
appfrosch wants to merge 1 commit intotechprimate:mainfrom
Open
Fetch objects from /add objects to a given PDFGroup#410appfrosch wants to merge 1 commit intotechprimate:mainfrom
PDFGroup#410appfrosch wants to merge 1 commit intotechprimate:mainfrom
Conversation
Member
|
Hi @appfrosch, thanks for opening up this pull request and your contribution. I am sorry for not responding for such a long time. Can you please explain me the use case of pre-rendered objects in a PDFGroup in more detail? The framework has been conceptualized to take objects as inputs to render exactly once, and are mapped from the high-level API models to internal objects. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In an app where I was using the package, I was confronted with the problem that I had already rendered content in a
PDFGroupthat I wanted to add to anotherPDFGroup.I am very sure that I am holding it extremely wrong and that there must be another solution to this problem already that I am not seeing–but at the same time, I came up with a solution that works for me:
PDFGroup.objectsarrayPDFGroup.add(_:_:)to to add anobject(which is a tuple ofPDFGroupContainerandPDFRenderObjectto aPDFGroupSince
PDFGroup.objectsis internal, anextensionfrom my own app didn't work–so I added the code to the package itself.I had this solution of mine in place now for a few months, but due to some git actions it seemed that my change had dissappeared from my local copy of the package–which meant I had to understand the problem (again) and reimplement my solution.
This time around I decided to fork the project though to not end up in a place where I have to reconstruct everything again–and also I thought, perhaps it might be of use to others as well, so why not create a pull request for it.
I am not that experienced when it comes to participating in open source, so let me know what I can improve on, if something comes to mind.
Also, and I'm repeating myself here, I am quite sure there must be a better solution to my problem–so if you can hint to that so that I can get rid of this hack again, please let me know